bugfix: fix transport exception when multi client connect to same ser…#47
Merged
AlbumenJ merged 3 commits intoapache:mainfrom Mar 24, 2025
Merged
bugfix: fix transport exception when multi client connect to same ser…#47AlbumenJ merged 3 commits intoapache:mainfrom
AlbumenJ merged 3 commits intoapache:mainfrom
Conversation
Member
|
@kifile Thank you very much for your contribution to the Dubbo community. I will conduct a code review as soon as possible. Before that, please refer to the CI and fix your code style.
|
Contributor
Author
|
@cnzakii , the unused imports is removed. |
cnzakii
reviewed
Mar 20, 2025
| @@ -77,6 +77,7 @@ def export(self, url: URL): | |||
| # Create a stream handler | |||
| stream_multiplexer = StreamServerMultiplexHandler(listener_factory) | |||
Member
There was a problem hiding this comment.
We have already passed in the listener_factory, so there is no need to pass in the StreamServerMultiplexHandler, since it is created in Http2Protocol; it should be removed here.
Contributor
Author
|
ok, I have removed the unused code. |
Member
|
@AlbumenJ LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The Http2Protocol stream-handler object is set by the `triple/protocol.py' defined when initialized.
When client connect to server, the asyncio will create a new http2protol using the same stream-handler object, and overwrite the _loop property. it results that the previous connections cannnot be resolved as expected.
It could be resolved by redefine the stream-handler in Http2Protocol
Brief changelog
Verifying this change