fix: add Enter key support to login and exclude Windows from Unix tests#1409
Open
ankitsharma101 wants to merge 1 commit intoapache:developfrom
Open
fix: add Enter key support to login and exclude Windows from Unix tests#1409ankitsharma101 wants to merge 1 commit intoapache:developfrom
ankitsharma101 wants to merge 1 commit intoapache:developfrom
Conversation
Part 1: Login UX Enhancement - Add form submission on Enter key press - Auto-focus username field on page load - Add @pressEnter handlers to both input fields - Import ref and onMounted from Vue composition API Part 2: Windows Build Fix - Add build tags to limits_test.go to exclude from Windows builds - Fixes golang.org/x/sys/unix import error on Windows - Aligns with existing limits.go build constraints Tested on Windows 11: - Go 1.24.6: Build succeeds without errors - Chrome/Edge: Enter key and auto-focus work correctly Fixes apache#1405
|
Author
|
Hi! I see the CI failed, but it looks like a file system error on the testing side. My changes only added Enter key support to the login form and build tags for Windows. These errors seem unrelated to my code. The build worked fine on my Windows machine. Should I do anything, or can you re-run the tests? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What This Fixes
Closes #1405
I ran into a couple of issues while trying to build Dubbo Admin on Windows 11:
limits_test.gotries to import Unix-specific packagesThis PR fixes both issues.
Changes Made
Login Form Improvements
The login form now works like you'd expect - press Enter and it submits. I also made it so the username field gets focus automatically when the page loads, which feels more natural.
What I changed:
@pressEnterhandlers to both input fields (using Ant Design Vue's built-in event)refandonMountedto auto-focus the username field on page loadWindows Build Fix
The test file
pkg/common/util/os/limits_test.gowas causing build failures on Windows because it importsgolang.org/x/sys/unix, which obviously doesn't exist on Windows.What I changed:
limits.goin the same directoryThe build tags look like this:
Testing
I tested everything on my Windows 11 machine with Go 1.24.6.
Login form:
/api/v1/auth/login)Windows build:
Before my changes, running
go buildwould fail with an error about the Unix package not being available. After adding the build tags, it builds successfully and creates thedubbo-admin.exefile (~97MB).Notes
I'm working on GSoC 2026 prep and trying to get Dubbo Admin running on Windows. These are real issues I hit while following the build instructions, so hopefully this helps other Windows developers too.
My Apache ICLA was confirmed on Feb 5, 2026.
Let me know if you'd like me to adjust anything!