[refactor](cloud) Rename cloud compute group metadata class#65817
Open
deardeng wants to merge 1 commit into
Open
[refactor](cloud) Rename cloud compute group metadata class#65817deardeng wants to merge 1 commit into
deardeng wants to merge 1 commit into
Conversation
deardeng
requested review from
924060929,
englefly,
gavinchou,
morrySnow and
starocean999
as code owners
July 20, 2026 08:43
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated review result: no blocking or correctness issues found.
The rename is complete and narrowly scoped. All cloud catalog metadata constructions, accessors, nested types, constants, and consumers now use CloudComputeGroupMeta, while every remaining ComputeGroup type belongs explicitly to the separate resource-routing abstraction. Normalizing the identifier across the authoritative diff leaves only formatting changes; no runtime condition, RPC payload, property, error path, or test assertion changed.
Critical checkpoint conclusions:
- Goal and tests: The PR removes the FE class-name ambiguity without changing behavior. The six updated FE test classes remain discoverable and cover metadata properties, physical/virtual group construction and synchronization, routing/failover helpers, warm-up validation, authorization, and ALTER validation. CheckStyle is green; COMPILE and FE UT are still pending. Per the automated-review contract, I performed static review only and did not run builds locally.
- Scope and parallel paths: The change is focused on the renamed class and every tracked production/test reference. Both physical-group construction in CloudSystemInfoService and virtual-group construction in CloudInstanceStatusChecker, plus the rebalancer and all three changed Nereids commands, are updated consistently.
- Concurrency and lifecycle: No thread entry, lock, lock order, shared-state operation, static initializer expression, ownership edge, or cleanup path changed.
- Compatibility and persistence: CloudComputeGroupMeta is process-local, is not EditLog/image/Java-serialized, and is reconstructed from MetaService protobufs. No reflection, service-loader, plugin/extension, logging configuration, or tracked class-name reference uses the old FQCN; FE/BE and rolling-upgrade wire formats are unchanged.
- Configuration, conditions, observability, and performance: No configuration, conditional behavior, transaction/data-write path, transmitted variable, log message/metric payload, allocation, scan, or hot-path work changed. The logger category follows the intentional class rename.
User focus: no additional review focus was provided.
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The FE cloud catalog metadata entity shared the ComputeGroup class name with the resource routing abstraction, making imports and usages ambiguous. Rename the cloud metadata entity to CloudComputeGroupMeta and update all production and unit-test references without changing runtime behavior or persisted metadata.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- ./run-fe-ut.sh --run org.apache.doris.cloud.catalog.CloudComputeGroupMetaTest,org.apache.doris.cloud.catalog.CloudInstanceStatusCheckerTest,org.apache.doris.cloud.system.CloudSystemInfoServiceTest,org.apache.doris.cloud.WarmUpClusterOnTablesParseTest,org.apache.doris.mysql.privilege.CloudAuthTest,org.apache.doris.nereids.trees.plans.commands.AlterComputeGroupCommandTest
- cd fe && mvn checkstyle:check -pl fe-core
- Behavior changed: No
- Does this need documentation: No
deardeng
force-pushed
the
rename-cloud-cg
branch
from
July 20, 2026 09:22
8587aee to
c29ab7b
Compare
Contributor
Author
|
run buildall |
morningman
approved these changes
Jul 20, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
TPC-H: Total hot run time: 29655 ms |
Contributor
TPC-DS: Total hot run time: 178384 ms |
Contributor
ClickBench: Total hot run time: 25.05 s |
Contributor
|
/review |
Contributor
There was a problem hiding this comment.
Review opinion: approve (comment-only review). I found no actionable correctness issue in the reviewed patch.
Critical checkpoint conclusions:
- Goal and proof: the PR disambiguates the FE cloud control-plane metadata type from the resource-layer routing
ComputeGroup. All in-repository production and test consumers move toCloudComputeGroupMeta, while the routing abstraction remains unchanged. Live CI reports Compile, FE UT, and CheckStyle passing. - Scope and clarity: the change is focused on one production class/test rename, declared-type/import/nested-type/constant substitutions, formatting required by the longer name, and explanatory Javadoc. No unrelated runtime logic is changed.
- Concurrency: the existing
CloudSystemInfoServiceread/write lock, concurrent maps, status-checker daemon, rebalancer, and query/failover interactions are unchanged; no lock, shared variable, thread entry, or lock ordering is added or modified. - Lifecycle/static initialization: physical metadata is reconstructed during backend refresh/replay and virtual metadata from meta-service
ClusterPBresponses. No new lifecycle edge, ownership cycle, or static initialization dependency is introduced. - Configuration: no configuration item or dynamic-update behavior is added or changed.
- Compatibility: no protobuf, FE-BE variable, RPC, image/EditLog, storage format, or rolling-upgrade contract changes. The renamed class is not
Writable/Java-serializable, is not registered in persisted Gson/class-tag paths, and is not part of the repository's plugin SPI; searches found no reflective/string consumer of the old cloud FQCN. - Parallel paths and conditions: physical/virtual lookup, active-standby failover, cache warm-up, tablet rebalancing, privilege handling, and ALTER/SHOW/WARM UP command paths are all updated consistently. No behavioral condition or error path changes.
- Tests and expected results: the renamed test still matches standard
*Testdiscovery, all six changed test files use the new type, and the PR's targeted test list covers them. Live FE UT is passing. The separatecheck_coverage_fe (Coverage)status is currently failing; its TeamCity log requires authentication and GitHub exposes no diagnostic, so this review cannot attribute it to a concrete code defect and does not claim an all-green matrix. - Observability: only the expected logger category changes with the class name; no old class-specific logging configuration exists, and no new logs/metrics are needed for a behavior-neutral rename.
- Transactions, persistence, and data writes: no transaction or user-data write path changes. Meta-service protobuf state remains the source of truth for virtual metadata, and persisted backend replay reconstructs physical metadata without Java class identity.
- Performance: operations, allocation patterns, lookup complexity, lock scope, and RPC behavior are unchanged.
- Other issues: repository-wide old-name/source/test/build/discovery searches and the final 14-file sweep found no missed consumer, accidental routing-type replacement, unresolved candidate, or inline-comment-worthy issue.
User focus: no additional focus was provided; the complete PR was reviewed.
Validation note: this automated review was static, as the runner contract forbids local builds. Round 1 converged with both normal full-review agents and the separate risk-focused agent returning NO_NEW_VALUABLE_FINDINGS against the same final ledger/comment set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The FE cloud catalog metadata entity shared the ComputeGroup class name with the resource routing abstraction, making imports and usages ambiguous. Rename the cloud metadata entity to CloudComputeGroupMeta and update all production and unit-test references without changing runtime behavior or persisted metadata.
Release note
None
Check List (For Author)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)