[fix](ci) cancel superseded buildall revisions#65813
Draft
hello-stephen wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary:
The
run buildallcomment workflow currently cancels queued/running builds one pipeline at a time immediately before each direct trigger. This does not cover downstream pipelines started by Compile, such as P0, External, Cloud P0, Vault P0, NonConcurrent, and coverage checks.As a result, after a PR receives a new revision and another
run buildallcomment, downstream builds for the previous revision can continue consuming TeamCity agents while the new revision is already queued or running. A live occurrence on PR #65644 left P0, External, Cloud P0, and NonConcurrent running on revision2302709bb4after revisiona9a716d174had started.This change adds one cancellation step to the existing comment-trigger workflow after the pipeline security check and before any new build is triggered. The step:
buildallpipeline IDs, including the downstream FE coverage check;The existing per-pipeline cancellation remains in place for standalone comments such as
run feutandrun p0.Release note
None
Check List (For Author)
Test
bash -n regression-test/pipeline/common/teamcity-utils.shgo run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/comment-to-trigger-teamcity.ymlBehavior changed:
run buildallcancels queued/running formal pipelines for older revisions of the same PR before triggering the new revision.Does this need documentation?
Check List (For Reviewer who merge this PR)