branch-4.0: [fix](cloud) set recycler S3 client requestTimeoutMs to avoid curl-28 on slow DeleteObjects (mirror #49315) #64758#65803
Open
github-actions[bot] wants to merge 1 commit into
Conversation
… on slow DeleteObjects (mirror #49315) (#64758) ## Proposed changes The cloud recycler builds its S3 client in `S3Accessor::init()` (`cloud/src/recycler/s3_accessor.cpp`) from an `Aws::Client::ClientConfiguration` that never sets `requestTimeoutMs`, so it keeps the SDK default of 3000ms. The vendored aws-sdk-cpp maps that to `CURLOPT_LOW_SPEED_TIME=3` / `CURLOPT_LOW_SPEED_LIMIT=1`, so any slow or large `DeleteObjects` request that can't sustain >1 byte/s for 3 seconds is aborted with curl error 28 ("Timeout was reached"). This is the same defect that #49315 fixed for the BE (`be/src/util/s3_util.cpp`, `requestTimeoutMs = 30000`), but the cloud recycler's client was missed by that change. On object stores with higher per-request latency (e.g. an OVH cold object-storage vault) the recycler wedges: every `delete_rowset_data` / `DeleteObjects` aborts at 3s with curlCode 28, the recycler burns its delete budget on timed-out ops, and the orphan backlog never drains. This change sets `requestTimeoutMs = 30000` and `connectTimeoutMs = 5000` on the recycler client, mirroring #49315. Symptom in MS recycler log before the fix: ``` s3_obj_client.cpp: failed to delete objects ... responseCode=-1 error="curlCode: 28, Timeout was reached" recycler.cpp: failed to delete rowset data, instance_id=... ``` ## Further comments Pure timeout-config change in the recycler S3 client path; no behavior change for fast object stores. `MaxDeleteBatch` is left unchanged. Signed-off-by: Steven Pall <mail@stevenpall.ca>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64758