Skip to content

[branch-4.1](compaction) remove single replica compaction (#63771)#64061

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
csun5285:pick-63771-branch-4.1
Jun 4, 2026
Merged

[branch-4.1](compaction) remove single replica compaction (#63771)#64061
yiguolei merged 1 commit into
apache:branch-4.1from
csun5285:pick-63771-branch-4.1

Conversation

@csun5285
Copy link
Copy Markdown
Contributor

@csun5285 csun5285 commented Jun 3, 2026

pick from master #63771

@csun5285 csun5285 requested a review from yiguolei as a code owner June 3, 2026 07:05
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Copy Markdown
Contributor Author

csun5285 commented Jun 3, 2026

run buildall

@csun5285 csun5285 force-pushed the pick-63771-branch-4.1 branch from 0f7804e to f03cea1 Compare June 3, 2026 07:31
@csun5285 csun5285 changed the title [chore](compaction) remove single replica compaction (#63771) [branch-4.1](compaction) remove single replica compaction (#63771) Jun 3, 2026
@csun5285
Copy link
Copy Markdown
Contributor Author

csun5285 commented Jun 3, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.38% (1903/2428)
Line Coverage 64.86% (33953/52347)
Region Coverage 65.34% (17492/26772)
Branch Coverage 54.02% (9282/17184)

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.93% (1/108) 🎉
Increment coverage report
Complete coverage report

Remove the single replica compaction (SRC) feature end-to-end across BE,
FE and regression tests.

Doc: apache/doris-website#3870

 ### Why remove it

The main reason is **correctness risk in peer selection**. A follower
replica had to pick a peer holding a "proper" version
(`_find_rowset_to_fetch`) and fetch its compacted result, based on
replica info that was only refreshed
periodically. Because replicas progress through versions independently
and this "leader" selection ran against a stale, time-sensitive view of
the cluster, the hoice of which peer to fetch from — and which version —
was racy and could select a peer whose state no longer matched, leading
to subtle inconsistencies.
@csun5285 csun5285 force-pushed the pick-63771-branch-4.1 branch from f03cea1 to 9d24026 Compare June 3, 2026 14:35
@yiguolei
Copy link
Copy Markdown
Contributor

yiguolei commented Jun 4, 2026

skip buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 9d31bf6 into apache:branch-4.1 Jun 4, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants