Skip to content

[fix](sql-functions) provide setup data for window-function examples querying an undefined table#3874

Merged
morningman merged 1 commit into
apache:masterfrom
boluor:fix/phantom-table-setup-window-functions
Jun 3, 2026
Merged

[fix](sql-functions) provide setup data for window-function examples querying an undefined table#3874
morningman merged 1 commit into
apache:masterfrom
boluor:fix/phantom-table-setup-window-functions

Conversation

@boluor
Copy link
Copy Markdown
Contributor

@boluor boluor commented Jun 2, 2026

The LAG, LEAD, NTILE, RANK and ROW_NUMBER window-function pages each show a SELECT ... FROM <table> example with an expected result, but never define the table on the page. As written these examples cannot be run or reproduced — a reader who copies them gets Table [...] does not exist.

This PR adds the missing CREATE TABLE + INSERT for each table, carried in a standard HTML comment (<!-- setup-sql ... -->) just before the example. Because it is an HTML comment, the rendered page is unchanged and no documented expected output is modified — it only records the data the examples already assume, making each example self-contained and reproducible.

Table contents were reverse-derived from the output already printed on each page and verified end-to-end on the matching release cluster for every doc tree.

Pages and tables

Function Table
LAG / LEAD stock_ticker
NTILE student_scores
RANK employees
ROW_NUMBER int_t

Each page is updated in EN + ZH across the dev/current, version-4.x, version-3.x and version-2.1 doc trees (40 files). Verification clusters: 4.1.1 (4.x), 3.1.4 (3.x), 2.1.11 (2.1), master build (dev). On every tree the affected examples failed with "table does not exist" before this change and pass (output matches the doc) after it. No ja-source changes.

🤖 Generated with Claude Code

…querying an undefined table

The LAG, LEAD, NTILE, RANK and ROW_NUMBER pages each show a `SELECT ... FROM <table>`
example with an expected result, but never define the table on the page, so the
examples cannot be run or reproduced ("table does not exist").

Add the missing CREATE TABLE + INSERT for each table (`stock_ticker` for LAG/LEAD,
`student_scores`, `employees`, `int_t`), carried in a standard HTML comment
(`<!-- setup-sql ... -->`) before the example. As an HTML comment it does not change
the rendered page, and no documented expected output is modified.

Table contents were reverse-derived from the output already printed on each page and
verified end-to-end on the matching release clusters: version-4.x on 4.1.1, version-3.x
on 3.1.4, version-2.1 on 2.1.11, and dev/current on a master build. On every tree the
examples failed with "table does not exist" before and now resolve and match the
documented output.

Pages updated in EN + ZH across dev/current, version-4.x, version-3.x and version-2.1.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@morningman morningman merged commit 28ea189 into apache:master Jun 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants