fix(kiro): align connection status and PostgreSQL dashboards - #9082
Open
warren830 wants to merge 2 commits into
Open
fix(kiro): align connection status and PostgreSQL dashboards#9082warren830 wants to merge 2 commits into
warren830 wants to merge 2 commits into
Conversation
Signed-off-by: warren <warren.chen830@gmail.com>
Signed-off-by: warren <warren.chen830@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
successandmessagefields to Kiro's detailed connection-test response so Config UI reports a successful S3 test as Connectedlake.qualifiers from three PostgreSQL Kiro dashboardsRoot cause
Kiro intentionally returns more connection diagnostics than most plugins, but its
ConnectionReportomitted the commonsuccessfield consumed by Config UI. The request returned HTTP 200 and S3 access succeeded, while the UI interpreted the missing field as false and displayed Disconnected.Three PostgreSQL dashboards also retained SQL generated from MySQL assumptions: database-qualified
lake._tool_kiro_*names,YEAR/MONTH, and a boolean-to-bigint cast. The tables are in PostgreSQL's active schema, so those panels failed when executed against a real PostgreSQL database.Validation
go test ./plugins/kiro/... -count=1go vet ./plugins/kiro/...go build ./plugins/kiro/...EXPLAINEXPLAINNotes
The detailed connection report remains backward compatible: existing diagnostic fields are unchanged and the shared status fields are additive.