Skip to content

To main #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leerho merged 15 commits into from
Mar 3, 2026
Merged

To main #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f72602d
update pom.xml and add testng.xml
leerho Feb 20, 2026
7071b96
update pom
leerho Feb 23, 2026
c075476
Update @BeforeSuite
leerho Feb 23, 2026
74c46ff
update pom.
leerho Feb 24, 2026
3082c72
Removed DOCTYPE link as unnecessary
leerho Feb 25, 2026
0b6bb80
Fix xml headers
leerho Feb 25, 2026
93d9b9b
update *.xml
leerho Feb 25, 2026
120d375
Add new auto-jdk-os-matrix.yml that uses reusable workflows.
leerho Feb 27, 2026
9a29f6e
update auto-jdk-os-matrix.yml
leerho Feb 28, 2026
9260eb9
Update caller
leerho Feb 28, 2026
cb65539
Add missing OS dimension
leerho Feb 28, 2026
8859a2a
Remove post-build-cleanup
leerho Feb 28, 2026
05b267f
Update Maven Central badge
leerho Mar 2, 2026
b399cfd
Update pom, .mvn to align w/ ds-java
leerho Mar 2, 2026
9ed7525
Update pom
leerho Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 19 additions & 54 deletions .github/workflows/auto-jdk-os-matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,66 +6,31 @@ on:
branches: [ 'main', '[0-9]+.[0-9]+.[Xx]', 'v[0-9]+.[0-9]+.[Xx]']
pull_request:
paths-ignore: [ '**/*.html', '**/*.md', '**/*.txt', '**/LICENSE', '**/NOTICE' ]
# The branches below must be a subset of the branches above
branches: [ 'main', '[0-9]+.[0-9]+.[Xx]', 'v[0-9]+.[0-9]+.[Xx]']
workflow_dispatch:
workflow_dispatch:

env:
MAVEN_OPTS: -Xmx4g -Xms1g
MAVEN_ARGS: "-B -Dmaven.javadoc.skip=true -Dgpg.skip=true"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build:
name: Build, Test, Install
runs-on: ${{ matrix.os }}

run-matrix:
strategy:
fail-fast: false
matrix:
jdk: [ 25 ]
os: [ windows-latest, ubuntu-latest, macos-latest ]

steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install Matrix JDK
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
java-package: jdk
architecture: x64
cache: 'maven' # performance optimization
overwrite-settings: true # ensures the runner's .m2/settings.xml is current

- name: Verify Toolchain Configuration
shell: bash
run: |
if [ -f ~/.m2/toolchains.xml ]; then
cat ~/.m2/toolchains.xml
else
echo "toolchains.xml not found in ~/.m2/"
fi

- name: Echo Java & Maven Version
run: mvn -version #also prints java-version

- name: Print Current workflow
run: cat .github/workflows/auto-jdk-os-matrix.yml

- name: Test
run: mvn clean test

- name: Install
run: mvn clean install "-DskipTests=true" "-Dmaven.clean.failOnError=false" #windows os hack


# Architecture options: x86, x64, armv7, aarch64, ppc64le
# Lifecycle: validate, compile, test, package, verify, install, deploy
# -B batch mode, never stops for user input
# -V show Version without stopping
# -X debug mode
# -q quiet, only show errors
include:
- os: windows-latest
arch: x64
- os: ubuntu-latest
arch: x64
- os: macos-latest
arch: aarch64

# Reference the reusable workflow on the "workflows" branch
uses: apache/datasketches-memory/.github/workflows/reusable-jdk-os-matrix.yml@workflows
Copy link
Member

@tisonkun tisonkun Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can simply inline the reuseable workflows at the main branch. Either under .github/workflows or under a new directory.

Copy link
Member Author

@leerho leerho Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to GitHub Docs, the reusable workflows (RWFs) can have the location syntax:
{owner}/{repo}/.github/workflows/{filename}@{ref} #in a different repo
OR
./.github/workflows/{filename}@{ref} #in the same repo
where {ref} can be a branch, tag, or gitHash.

I would prefer having the RWFs in a separate branch ... or a common repo ... hmm...
I have it in a separate branch here, but these RWFs would be identical to what we would need for DS-Java.
Perhaps a better idea would be to put these in a "workflows" branch on DS-Java. It would be a natural common place for all the various java repos. Since trying to share RWFs across different languages may be too cumbersome.

Actually, I'd prefer if you would approve it here so I can test it. And then if it works, I'll move the "workflows" directory to DS-Java, where it makes more sense and can be leveraged by other DS-"java" repos, like hive, pig, characterization, vector, server, etc (that is, if we want to upgrade them :) )

with:
jdk_version: ${{ matrix.jdk }}
os_type: ${{ matrix.os }}
java_arch: ${{ matrix.arch }}
5 changes: 5 additions & 0 deletions .mvn/maven.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# suppresses the warning:
# Direct modification of testCompileSourceRoots through add() is deprecated and will not work in Maven 4.0.0. Please use the add/remove methods instead.
# If you're using a plugin that causes this warning, please upgrade to the latest version and report an issue if the warning persists.
# To disable these warnings, set -Dmaven.project.sourceRoots.warningsDisabled=true on the command line or in the .mvn/maven.config file.
-Dmaven.project.sourceRoots.warningsDisabled=true
13 changes: 0 additions & 13 deletions DS-Java-Memory-24.code-workspace
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
-->

[![Build Status](https://travis-ci.org/apache/datasketches-memory.svg?branch=master)](https://travis-ci.org/apache/datasketches-memory)
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.apache.datasketches/datasketches-memory/badge.svg)](https://maven-badges.herokuapp.com/maven-central/org.apache.datasketches/datasketches-memory)
[![Coverage Status](https://coveralls.io/repos/github/apache/datasketches-memory/badge.svg?branch=master)](https://coveralls.io/github/apache/datasketches-memory?branch=master)
[![Maven Central](https://img.shields.io/maven-central/v/org.apache.datasketches/datasketches-memory)](https://central.sonatype.com/artifact/org.apache.datasketches/datasketches-memory)
[![Coverage Status](https://coveralls.io/repos/github/apache/datasketches-memory/badge.svg?branch=main)](https://coveralls.io/github/apache/datasketches-memory?branch=main)

=================

Expand Down
Loading