Conversation
This only involved mostly public classes.
name changes for Theta.
Note that I focused on changing the name of public classes where they might conflict with similarly named classes in other families, particularly the /theta/ and /tuple/ families.
In KLL, I changed the names of the enum constants to KLL_DOUBLES_SKETCH, etc. And the methods to isKllItmesSketch(), etc.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I have completed, I think, all the necessary name changes for /theta/ and /tuple/ -- 124 files, I primarily focused on the public classes and methods where:
Bear in mind that there are no code logic changes whatsoever. But of course, the name changes constitute breaking changes on their own. All the unit tests run just fine, even the CI tests. Nonetheless, CoPilot complained about the fact that the deprecated methods are still used in test, and still have a few transient references in /main/ that a are unavoidable — unless we remove all of the deprecated methods, which I don’t have the energy or desire to do for this release. CoPilot also complained about unused variables in the tests -- which I mostly fixed - although I'm not too concerned about this in test code. If I can get this quickly approved and merged by Oct 18th, I might -- but no guarantees -- have the time to do a release before I leave on a long vacation. Otherwise, it will have to wait until the 2nd week in November. |
leerho
requested review from
AlexanderSaydakov,
c-dickens,
davecromberge,
freakyzoidberg and
jmalkin
2 participants
This pretty much completes the change of class names that were either in conflict with other sketch families or could cause confusion. For example, the "LongsSketch" in FrequentItems is now "FrequentLongsSketch", etc. I also changed the names of some enum constants to be consistent.