Conversation
leerho
requested review from
AlexanderSaydakov,
frankgrimes97,
freakyzoidberg and
jmalkin
jmalkin
approved these changes
Mar 30, 2025
Contributor
jmalkin
left a comment
jmalkin
left a comment
There was a problem hiding this comment.
I do wish we'd find a better solution for that CPC test code than to stick it in main. But not gonna condition approving this on solving that.
| * | ||
| * Start the merging validation process | ||
| */ | ||
| public void start() { |
Contributor
There was a problem hiding this comment.
That this class exists in the main code at all is kind of ugly, imho. Sigh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All but one of these changes are Javadoc changes to satisfy new Javadoc checks introduced with Java 21.
The new requirements are that all public methods and classes must have a Javadoc description. A new twist is that public static classes that don't really need a constructor, must have a constructor with a description!