Test: pin arrow-rs to apache/arrow-rs#10719 (new PageIndex struct) - #24504
Draft
alamb wants to merge 8 commits into
Draft
Test: pin arrow-rs to apache/arrow-rs#10719 (new PageIndex struct)#24504alamb wants to merge 8 commits into
PageIndex struct)#24504alamb wants to merge 8 commits into
Conversation
Pin arrow/parquet crates to arrow-rs rev 901e69f913bb8a1738009218898959e8f4cd7ec8 via [patch.crates-io] until arrow 60.0.0 is released. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tore 0.14, etc) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # datafusion/core/tests/user_defined/user_defined_aggregates.rs # datafusion/core/tests/user_defined/user_defined_scalar_functions.rs # datafusion/core/tests/user_defined/user_defined_window_functions.rs # datafusion/ffi/src/udaf/mod.rs # datafusion/optimizer/src/optimizer.rs
These changes are needed because apache/arrow-rs#10719 is based on an older arrow-rs main than the pin in apache#24366, which lacks Metadata::as_arc and Metadata::retain. Not related to the PageIndex API change itself.
Replace uses of ParquetMetaData::column_index/offset_index and ParquetColumnIndex/ParquetOffsetIndex with the new PageIndex struct and its accessors.
github-actions
Bot
added
sql
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24504 +/- ##
==========================================
- Coverage 81.27% 81.26% -0.02%
==========================================
Files 1114 1114
Lines 393619 393623 +4
Branches 393619 393623 +4
==========================================
- Hits 319931 319893 -38
- Misses 54950 54985 +35
- Partials 18738 18745 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PageIndexstruct to encapsulate column and offset indexes arrow-rs#10719Note: this PR is for testing only and is not intended for merge
Rationale for this change
Test how the new
PageIndexstruct proposed in apache/arrow-rs#10719 would work with DataFusion.See the changes needed by the API here
What changes are included in this PR?
On top of the commits from #24366:
Are these changes tested?
By existing CI
Are there any user-facing changes?
No