chore(join): refactor BitwiseSortMergeJoinStream to use generators instead of manual state#23726
Draft
rluvaton wants to merge 1 commit into
Draft
chore(join): refactor BitwiseSortMergeJoinStream to use generators instead of manual state#23726rluvaton wants to merge 1 commit into
BitwiseSortMergeJoinStream to use generators instead of manual state#23726rluvaton wants to merge 1 commit into
Conversation
…instead of manual state This is just copy line by line to async without cleanup of the state that is being used for saving when moving between polls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to review yet
This is just copy line by line to async without cleanup of the state that is being used for saving when moving between polls
Which issue does this PR close?
N/A
Rationale for this change
Trying to see if I can make the code simpler
What changes are included in this PR?
moved to generator
Are these changes tested?
existing tests
Are there any user-facing changes?
no