feat(substrait): add extension table consumer hook#23724
Draft
kadinrabo wants to merge 1 commit into
Draft
Conversation
vbarua
reviewed
Jul 20, 2026
| consumer | ||
| .consume_extension_table(read, extension_table) | ||
| .await | ||
| } |
Contributor
There was a problem hiding this comment.
One bit of API that might be worth thinking about if you haven't already.
The NamedTable and LocalFiles read_types call the read_with_schema function at the end to also translate the projection, and filter fields of the ReadRel message. read_with_schema assumes that the translated read_type is vaguely TableReference shaped
With the addition of ExtensionTable, we have two read_types that aren't TableReference shaped (the other is VirtualTable) and don't correctly handle the projection and filter fields. Now might be a good time to try and figure out a better abstraction to handle those fields consistently for all read types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom consumers can already override
consume_read, but handling onlyReadRel::ExtensionTablemeans copying the rest offrom_read_rel.This adds the same narrow hook used for extension relation cases. It doesn't add producer support or default table serialization.
Part of #13771
Tested with
cargo test -p datafusion-substrait