fix: support parentheses for negative decimal formatting#23718
Open
wangzhigang1999 wants to merge 1 commit into
Open
fix: support parentheses for negative decimal formatting#23718wangzhigang1999 wants to merge 1 commit into
wangzhigang1999 wants to merge 1 commit into
Conversation
wangzhigang1999
marked this pull request as ready for review
July 20, 2026 11:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Spark and Java format negative numeric values with parentheses when the
(flag is present. The decimal formatting path always emitted a minus sign because it ignorednegative_in_parentheses, while the floating-point path already handled the flag. This madeformat_stringinconsistent across numeric input types.What changes are included in this PR?
Are these changes tested?
Yes. The following checks pass locally:
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion-spark --libavro,json,backtrace,extended_tests,recursive_protection,parquet_encryptionenabledAre there any user-facing changes?
Yes. Spark-compatible formatting of negative decimal values now honors the parentheses flag. There are no public API or breaking changes.