Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20167,15 +20167,34 @@ impl<'a> Parser<'a> {
}

fn parse_pragma_value(&mut self) -> Result<ValueWithSpan, ParserError> {
let v = self.parse_value()?;
let span = self.peek_token_ref().span;
let v = match self.parse_one_of_keywords(&[
Keyword::TRUE,
Keyword::FALSE,
Keyword::ON,
Keyword::OFF,
Keyword::YES,
Keyword::NO,
]) {
Some(keyword) => Value::Boolean(matches!(
keyword,
Keyword::TRUE | Keyword::YES | Keyword::ON
))
.with_span(span),
None => self.parse_value()?,
};
match &v.value {
Value::SingleQuotedString(_) => Ok(v),
Value::DoubleQuotedString(_) => Ok(v),
Value::Number(_, _) => Ok(v),
Value::Boolean(_) => Ok(v),
Value::Placeholder(_) => Ok(v),
_ => {
self.prev_token();
self.expected_ref("number or string or ? placeholder", self.peek_token_ref())
self.expected_ref(
"boolean, number, string, or ? placeholder",
self.peek_token_ref(),
)
}
}
}
Expand Down
62 changes: 60 additions & 2 deletions tests/sqlparser_sqlite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ use sqlparser::ast::SelectItem::UnnamedExpr;
use sqlparser::ast::Value::Placeholder;
use sqlparser::ast::*;
use sqlparser::dialect::{GenericDialect, SQLiteDialect};
use sqlparser::parser::{ParserError, ParserOptions};
use sqlparser::tokenizer::Token;
use sqlparser::parser::{Parser, ParserError, ParserOptions};
use sqlparser::tokenizer::{Span, Token};

#[test]
fn pragma_no_value() {
Expand Down Expand Up @@ -971,3 +971,61 @@ fn sqlite_and_generic() -> TestedDialects {
Box::new(GenericDialect {}),
])
}

#[test]
fn pragma_boolean_values() {
for (spelling, expected) in [
("TRUE", true),
("YES", true),
("ON", true),
("FALSE", false),
("NO", false),
("OFF", false),
] {
let sql = format!("PRAGMA case_sensitive_like = {spelling}");
let canonical = format!("PRAGMA case_sensitive_like = {expected}");
let statement = sqlite_and_generic().one_statement_parses_to(&sql, &canonical);
assert!(matches!(
statement,
Statement::Pragma {
value: Some(ValueWithSpan {
value: Value::Boolean(actual),
..
}),
is_eq: true,
..
} if actual == expected
));
}
let statements =
Parser::parse_sql(&SQLiteDialect {}, "PRAGMA case_sensitive_like = oN").unwrap();
let [Statement::Pragma {
value:
Some(ValueWithSpan {
value: Value::Boolean(true),
span,
}),
is_eq: true,
..
}] = statements.as_slice()
else {
panic!("Expected equality-form PRAGMA")
};
assert_eq!(&Span::new((1, 30).into(), (1, 32).into()), span);

let statement = sqlite_and_generic().one_statement_parses_to(
"PRAGMA case_sensitive_like(ON)",
"PRAGMA case_sensitive_like(true)",
);
assert!(matches!(
statement,
Statement::Pragma {
value: Some(ValueWithSpan {
value: Value::Boolean(true),
..
}),
is_eq: false,
..
}
));
}
Loading