Accept CREATE OR REPLACE SCHEMA - #2396
Merged
Merged
Conversation
sabir-akhadov-localstack
force-pushed
the
pr/04-create-or-replace-schema
branch
from
July 2, 2026 13:17
d5e66f5 to
782f668
Compare
Add an `or_replace: bool` field to `Statement::CreateSchema` and route the SCHEMA keyword ahead of the `or_replace` allowlist bail-out in `Parser::parse_create` so that `CREATE OR REPLACE SCHEMA [IF NOT EXISTS] foo` parses successfully. Display round-trips OR REPLACE.
sabir-akhadov-localstack
force-pushed
the
pr/04-create-or-replace-schema
branch
from
July 2, 2026 13:19
782f668 to
a772d1d
Compare
sabir-akhadov-localstack
marked this pull request as ready for review
July 2, 2026 13:20
|
Just wondering: what dialect does support |
Contributor
Author
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
iffyio
approved these changes
Jul 27, 2026
iffyio
left a comment
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @sabir-akhadov-localstack!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE OR REPLACE SCHEMA did not parse.
CREATE SCHEMAwas handled after theOR REPLACEallowlist bail-out inparse_create, so anyOR REPLACEin front of it produced an error:This routes the
SCHEMAkeyword ahead of that bail-out and adds anor_replace: boolfield toStatement::CreateSchema. Display round-tripsOR REPLACE.