Fix Hive SKEWED BY display - #2395
Open
wenxiaojie1 wants to merge 2 commits into
Open
Conversation
iffyio
reviewed
Jul 27, 2026
Comment on lines
+231
to
+249
| fn display_create_table_with_skewed_by() { | ||
| let column = |name| ColumnDef { | ||
| name: Ident::new(name), | ||
| data_type: DataType::String(None), | ||
| options: vec![], | ||
| }; | ||
| let stmt = CreateTableBuilder::new(ObjectName::from(vec![Ident::new("test")])) | ||
| .columns(vec![column("id")]) | ||
| .hive_distribution(HiveDistributionStyle::SKEWED { | ||
| columns: vec![column("id")], | ||
| on: vec![column("id")], | ||
| stored_as_directories: true, | ||
| }) | ||
| .build(); | ||
|
|
||
| assert_eq!( | ||
| stmt.to_string(), | ||
| "CREATE TABLE test (id STRING) SKEWED BY (id STRING) ON (id STRING) STORED AS DIRECTORIES" | ||
| ); |
Contributor
There was a problem hiding this comment.
can we simplify the test to use the format here for example?
https://github.com/wenxiaojie1/datafusion-sqlparser-rs/blob/30b2a5a686135af090cf7e757070143f36cdff84/tests/sqlparser_hive.rs#L122-L125
Author
There was a problem hiding this comment.
Thanks. I tried the verified_stmt form, but the current Hive parser rejects this syntax with Expected: end of statement, found: SKEWED. Issue #1499 explicitly notes that SKEWED BY cannot currently be parsed. I kept the explicit AST construction so the test remains scoped to the reported display bug rather than adding parser support in this PR. The focused test still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1499.
This removes the extra closing parenthesis when formatting Hive SKEWED BY clauses and adds a display test for the constructed AST.
Checked locally: