-
Notifications
You must be signed in to change notification settings - Fork 755
Doris SQL: add Doris Dialect #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use crate::dialect::Dialect; | ||
|
|
||
| /// A [`Dialect`] for [Apache Doris](https://doris.apache.org/). | ||
| #[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct DorisDialect {} | ||
|
|
||
| impl Dialect for DorisDialect { | ||
| fn is_delimited_identifier_start(&self, ch: char) -> bool { | ||
| ch == '`' | ||
| } | ||
|
|
||
| fn identifier_quote_style(&self, _identifier: &str) -> Option<char> { | ||
| Some('`') | ||
| } | ||
|
|
||
| fn is_identifier_start(&self, ch: char) -> bool { | ||
| ch.is_ascii_alphabetic() || ch == '_' || !ch.is_ascii() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since these methods at this time are extensively identical and meant to be identical to the |
||
| } | ||
|
|
||
| fn is_identifier_part(&self, ch: char) -> bool { | ||
| self.is_identifier_start(ch) || ch.is_ascii_digit() | ||
| } | ||
|
|
||
| fn supports_string_literal_backslash_escape(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| fn ignores_wildcard_escapes(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| fn supports_numeric_prefix(&self) -> bool { | ||
| true | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #![warn(clippy::all)] | ||
| //! Test SQL syntax specific to Apache Doris. | ||
|
|
||
| #[macro_use] | ||
| mod test_utils; | ||
|
|
||
| use sqlparser::dialect::{Dialect, DorisDialect, GenericDialect}; | ||
| use test_utils::*; | ||
|
|
||
| fn doris() -> TestedDialects { | ||
| TestedDialects::new(vec![Box::new(DorisDialect {})]) | ||
| } | ||
|
|
||
| fn doris_and_generic() -> TestedDialects { | ||
| TestedDialects::new(vec![Box::new(DorisDialect {}), Box::new(GenericDialect {})]) | ||
| } | ||
|
|
||
| #[test] | ||
| fn doris_identifier_and_string_literal_gates() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am unsure such a test is necessary |
||
| let dialect = DorisDialect {}; | ||
| assert_eq!(dialect.identifier_quote_style("identifier"), Some('`')); | ||
| assert!(dialect.is_delimited_identifier_start('`')); | ||
| assert!(dialect.supports_string_literal_backslash_escape()); | ||
| assert!(dialect.ignores_wildcard_escapes()); | ||
| assert!(dialect.supports_numeric_prefix()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn parse_doris_strings_and_identifiers() { | ||
| doris().verified_stmt( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe here you may want to use |
||
| r#"SELECT "double quoted string", 'single quoted string', `select` FROM `db`.`table`"#, | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn doris_and_generic_parse_common_sql_identically() { | ||
| doris_and_generic().verified_stmt("SELECT 1 AS properties FROM t"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I imagine this will be more relevant in a later PR in this series where you add the keyword |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you are still currently missing:
supports_limit_commaparse_infix(theDIV)supports_group_by_with_modifierI am not familiar enough with Doris to say anything about the other methods, but I suggest you audit them against the engine.