Add Tokenizer custom token mapper support - #2184
Merged
Merged
Conversation
askalt
force-pushed
the
askalt/tokenizer-iterator
branch
from
January 26, 2026 07:16
1af5611 to
2bd5c9c
Compare
novartole
reviewed
Jan 27, 2026
novartole
left a comment
novartole
left a comment
There was a problem hiding this comment.
Thank you for the patch! Please have a look at my suggestions.
novartole
reviewed
Jan 27, 2026
askalt
force-pushed
the
askalt/tokenizer-iterator
branch
2 times, most recently
from
January 28, 2026 06:56
b4445d5 to
8324527
Compare
askalt
force-pushed
the
askalt/tokenizer-iterator
branch
from
February 2, 2026 07:13
8324527 to
284f512
Compare
Contributor
Author
|
@iffyio Could you review please? |
askalt
force-pushed
the
askalt/tokenizer-iterator
branch
from
February 4, 2026 07:50
284f512 to
141363b
Compare
iffyio
reviewed
Feb 6, 2026
askalt
force-pushed
the
askalt/tokenizer-iterator
branch
3 times, most recently
from
February 6, 2026 12:53
589f832 to
e83a0d4
Compare
iffyio
approved these changes
Feb 6, 2026
iffyio
changed the title
iffyio
changed the title
Contributor
|
@askalt could you take a look at the conflicts on the branch when you get some time? |
This patch adds a method to map tokens with provided mapper during tokenization. This way tokens could be replaced without an additional pass.
askalt
force-pushed
the
askalt/tokenizer-iterator
branch
from
February 6, 2026 16:12
e83a0d4 to
cc288fe
Compare
Contributor
Author
Yep, done, thank you for review! |
fmguerreiro
pushed a commit
to fmguerreiro/datafusion-sqlparser-rs
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a method to map tokens with provided mapper during
tokenization. This way tokens could be replaced without an additional
pass.