Repository navigation
test: skip nanvl records that need simplify in evaluate mode - #377
Merged
Merged
Conversation
nanvl's lazy expr2 and its string casts come only from its simplify rewrite, so seven records fail in the evaluate mode added by apache#316. Skip them there, linking apache#376. Also use '-0.0'::double, since Spark types -0.0 as a DECIMAL literal, which has no negative zero.
mbutrovich
approved these changes
Nov 19, 2026
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix, @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #376.
Rationale for this change
mainfails CI since #301 and #316 landed together.conditional/nanvl.sltfails in the new evaluate mode, and the PySpark runner reports a difference at line 53.What changes are included in this PR?
nanvl'ssimplifyrewrite (a lazy expr2 under ANSI mode, and string arguments) are markedskipif evaluate, linking nanvl needs simplify for a lazy expr2 and for string arguments #376.-0.0::double, which Spark types as a DECIMAL literal with no negative zero, so Spark returnedfalse. It now uses'-0.0'::double, aslog1p.sltdoes.Are these changes tested?
nanvl.sltpasses in both modes, and the PySpark runner reports no differences for it.Are there any user-facing changes?
No.