Repository navigation
fix(spark): url_decode replaces invalid utf-8 like spark - #372
Open
TechWizard9999 wants to merge 3 commits into
Open
TechWizard9999 wants to merge 3 commits into
TechWizard9999 wants to merge 3 commits into
Conversation
Contributor
Author
|
@andygrove Please review. Thanks. |
andygrove
requested changes
Nov 19, 2026
andygrove
left a comment
Member
There was a problem hiding this comment.
Thanks for this. The fix is in the right place and the #[user_doc] update and the removed xfail markers are just what #366 needed. I rebased onto main locally and all the url/ files pass in both modes, and the PySpark runner agrees on every record. I left one comment about encoded surrogates, where Java's decoder still gives a different number of U+FFFD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Explained in the issue.
What changes are included in this PR?
Bytes that are not valid utf-8 become the replacement character, like spark. a bad percent escape is still an error.
Are these changes tested?
Yes, updated the slt tests for both functions.
Are there any user-facing changes?
Yes, invalid utf-8 gives the replacement character instead of an error or null.