Skip to content

build: depend on the DataFusion 56.0.0-rc2 tag instead of branch-56 - #370

Open
andygrove wants to merge 2 commits into
apache:mainfrom
andygrove:df-56-rc2
Open

andygrove wants to merge 2 commits into
apache:mainfrom
andygrove:df-56-rc2

Conversation

@andygrove

Copy link
Copy Markdown
Member

Which issue does this PR close?

Rationale for this change

main depends on DataFusion's branch-56 as a git dependency, so the DataFusion code we build against changes whenever branch-56 moves. Pinning to the 56.0.0-rc2 tag means we build and test against the release candidate. When DataFusion 56.0.0 is published, a follow-up PR moves to the crates.io release.

What changes are included in this PR?

  • The DataFusion dependencies in Cargo.toml and crates/sqllogictest/Cargo.toml use tag = "56.0.0-rc2" instead of branch = "branch-56". Cargo.lock changes only the DataFusion git sources.
  • The note on git dependencies in dev/release/README.md now mentions tags too.

Are these changes tested?

By the existing tests in CI. Locally, everything passes except math/expm1.slt, which also fails on main on macOS (#358, fixed by #359).

Are there any user-facing changes?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant