Repository navigation
feat(spark): add Spark-compatible ln, log, log10, log2 and log1p #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andygrove
wants to merge
7
commits into
apache:main
Choose a base branch
from
andygrove:feat-spark-log-functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f6dd8dc
feat(spark): add Spark-compatible ln, log, log10, log2 and log1p
andygrove 69c97d1
fix(spark): compute expm1 with a translation of fdlibm's s_expm1.c
andygrove 917ac68
fix(spark): accept string arguments in the log functions and error on…
andygrove 2afb933
docs(spark): link the shared input-type coercion issue from float64_c…
andygrove e520f45
docs(spark): fix private fdlibm doc links and note Spark's d/f string…
andygrove f1c3998
test(spark): mark ln's string cast differences with xfail comments
andygrove 3d89535
Merge remote-tracking branch 'apache/main' into HEAD
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fdlibm notice is the SPDX
SunProlicense, which isn't named in the ASF's Category A list. There is precedent: Lucene ships fdlibm-derived code with the Apache header on top and the Sun notice in a comment (SloppyMath.java). The ASF header policy also says not to put the Apache header on third-party source files, and it leaves major modifications to the PMC. A line-by-line translation falls between those two cases.Could you ask on legal-discuss@ whether
SunProis Category A and which headerfdlibm.rsshould carry, and link the answer here? I'd like that settled before this merges.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this. I'll ask on legal-discuss@ and link the thread here once there's an answer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, while we wait on legal-discuss@: arrow already depends on code under this same notice.
arrow-arrayenableshalf'snum-traitsfeature, which enablesnum-traits'libmfeature. Fifty oflibm's source files carry the Sun notice, and its LICENSE reproduces it. That is a dependency rather than code in our source release, so it does not settle the question here. I also checked whether we could uselibminstead. It differs fromStrictMathon about 1% ofloginputs and 11% oflog10inputs, but it matchesexpm1exactly.