Simplify HTML Formatter Style Handling Using Script Injection#1177
Merged
timsaucer merged 1 commit intoapache:mainfrom Jul 4, 2025
Merged
Simplify HTML Formatter Style Handling Using Script Injection#1177timsaucer merged 1 commit intoapache:mainfrom
timsaucer merged 1 commit intoapache:mainfrom
Conversation
timsaucer
approved these changes
Jul 4, 2025
Member
timsaucer
left a comment
There was a problem hiding this comment.
Thank you for this!
Also, I recently implemented custom formatter for some code in another project and it worked like a charm! These features are excellent.
Contributor
Author
|
You're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This change simplifies the logic for injecting HTML styles in the
DataFrameHtmlFormatterclass. The previous implementation relied on a class-level_styles_loadedflag to prevent redundant style injection, which introduced state management complexity and testing challenges. By using a<script>block that conditionally appends styles based on DOM inspection, this new approach avoids side effects and supports better isolation across render calls and notebook sessions.What changes are included in this PR?
_styles_loadedflag and associated logic.reset_styles_loaded_statefunction and its test usages.Are these changes tested?
Yes, all existing relevant tests have been updated to reflect the new behavior. Assertions now check for presence of the injected script rather than
<style>tags. This ensures that styles are being correctly applied through the new mechanism.Are there any user-facing changes?
Yes, but minimal:
reset_styles_loaded_state.<script>-based style injection, which improves compatibility and reduces potential styling issues across multiple renderings.