Repository navigation
fix: honor write.object-storage.enabled in IcebergWriteExec - #121
Draft
smaheshwar-pltr wants to merge 3 commits into
Draft
smaheshwar-pltr wants to merge 3 commits into
smaheshwar-pltr wants to merge 3 commits into
Conversation
`IcebergWriteExec` always used `DefaultLocationGenerator`, so tables
with `write.object-storage.enabled=true` got the default
`{data}/{partition path}/{file}` layout instead of hashed paths, and
`write.object-storage.partitioned-paths=false` had no effect. Use
`TableLocationGenerator`, which picks the layout from the table
properties.
INSERT now fails when a `write.object-storage.*` property has an
invalid value, instead of ignoring it.
Move object-storage INSERT tests into the split test suite. Generated-by: Codex
Compare each data file path with its expected layout, with the hash directories and generated file name redacted, instead of rebuilding the expected path with `ObjectStorageLocationGenerator`. Also check that INSERT rejects an invalid `write.object-storage.enabled`. Generated-by: Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smaheshwar-pltr
commented
Nov 19, 2026
| .await?; | ||
|
|
||
| assert_eq!( | ||
| redacted_data_file_paths(&fixtures).await?, |
Contributor
Author
There was a problem hiding this comment.
With apache/iceberg-rust#3730, we could rely on Iceberg Rust behaviour and instead here just check that the file path matches what ObjectStorageLocationGenerator would yield by using it directly. I thought that being more explicit in the actual paths we expect might be nicer hence gone with this
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122.
// Outline for now as requires apache/iceberg-rust#3730.