Repository navigation
fix: load each table from the catalog on lookup - #116
Draft
NoahKusaba wants to merge 1 commit into
Draft
NoahKusaba wants to merge 1 commit into
NoahKusaba wants to merge 1 commit into
Conversation
NoahKusaba
marked this pull request as ready for review
November 18, 2026 14:53
Contributor
Author
|
Line count is inflated by tests. |
NoahKusaba
marked this pull request as draft
November 19, 2026 18:51
NoahKusaba
force-pushed
the
fix/fresh-table-lookup
branch
from
November 19, 2026 19:10
60c87e8 to
fc85b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
IcebergSchemaProviderbuilds each table's provider once, when the catalog is registered, and every query reuses it with the schema the table had then. After another client changes the schema, INSERTs fail (#56) and reads return wrong results or panic (#57).What changes are included in this PR?
IcebergSchemaProviderkeeps only table names. Eachtable()lookup loads the table and builds a new provider, including for$metadata tables.IcebergCatalogTableProvider::metadata_table.Table names are still listed once, so tables other clients create or drop stay invisible (rest of #24).
Are there any user-facing changes?
Queries see schema changes made by other clients. Each lookup costs one
load_table, on top of the onescan/insert_intoalready does; a follow-up can have the provider reuse the loaded table. No API changes.Are these changes tested?
Yes.
tests/table_lookup.rshas a session use a table, another client change its schema, and the session use it again. Both tests fail onmainwith the errors from the issues.