Repository navigation
feat: report snapshot row count statistics to DataFusion #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
85f6b1b
feat: report snapshot row count statistics to DataFusion
mbutrovich 3ef58a1
address review: clarify statistics docs, deterministic test timestamps
mbutrovich 13b6b3e
address PR feedback
mbutrovich c5c9d53
Merge remote-tracking branch 'upstream/main' into table-statistics
mbutrovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use datafusion::error::Result; | ||
| use iceberg_datafusion::test_utils::IcebergTestHarness; | ||
|
|
||
| #[tokio::test] | ||
| async fn reports_the_snapshot_row_count_to_datafusion() -> Result<()> { | ||
| let harness = IcebergTestHarness::new().await?; | ||
| harness | ||
| .query("SET datafusion.explain.show_statistics = true") | ||
| .await?; | ||
| let (_, explain) = harness.query("EXPLAIN SELECT vendor_id FROM taxi").await?; | ||
|
|
||
| insta::assert_snapshot!(explain, @r" | ||
| +---------------+---------------------------------------------------------------------------------------------------------------------------------+ | ||
| | plan_type | plan | | ||
| +---------------+---------------------------------------------------------------------------------------------------------------------------------+ | ||
| | logical_plan | TableScan: taxi projection=[vendor_id] | | ||
| | physical_plan | CooperativeExec, statistics=[Rows=Inexact(175000), Bytes=Inexact(700000), [(Col[0]:)]] | | ||
| | | DataSourceExec: format=iceberg, projection=[vendor_id], statistics=[Rows=Inexact(175000), Bytes=Inexact(700000), [(Col[0]:)]] | | ||
| | | | | ||
| +---------------+---------------------------------------------------------------------------------------------------------------------------------+ | ||
| "); | ||
|
|
||
| Ok(()) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This snapshot pattern comes up frequently, I wonder if we should just resolve the snapshot once during data source construction. Not for this PR though,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to resolving the snapshot once at construction. Could we file an issue for it so it doesn't get lost, and link it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #118