Repository navigation
feat: admit S3FileIO's AssumeRoleAwsClientFactory for native Iceberg writes #7680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
surawut-jirasaktavee
wants to merge
1
commit into
apache:main
Choose a base branch
from
surawut-jirasaktavee:iceberg-write-assume-role-client-factory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+220
−14
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without
client.factory, iceberg-java ignoresclient.assume-role.*(AwsClientFactories.fromdefaults toDefaultAwsClientFactory, and aHadoopFileIOwrite goes through S3A). Butclient.assume-role.arn,external-idandsession-nameare inSupportedS3FileIOPropertiesunconditionally, and the test atunsupported(assumeRole - "client.factory") == Seq("client.assume-role.region")shows that an ARN without the factory is still admitted when no region is set. The native writer then assumes the role while the JVM writer would have used the default credentials, so the write happens under a different identity. This predates the PR, but the PR description states the rule and this is the place to enforce it. Consider declining the ARN, external id and session name unlessassumeRoleholds and the FileIO isS3FileIO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here.
client.assume-role.arn,external-idandsession-nameare no longer inSupportedS3FileIOProperties. They are admitted only together withclient.factory=AssumeRoleAwsClientFactory, a non-blank arn and region, andS3FileIO, so an ARN without the factory now falls back. I updated the existing supported-keys test and added a case for the assume-role keys without the factory