Repository navigation
fix: [branch-1.2] locate the test UDF library under Cargo's Rust 1.100 build layout (#7617) - #7665
Merged
Conversation
apache#7617) Rust 1.100 splits the build script output directory into <pkg>/<hash>, so the fixed-depth ancestor lookup in native/core/build.rs resolved COMET_TEST_UDFS_LIB to target/<profile>/build instead of target/<profile>. Find the profile directory as the parent of the nearest build ancestor of OUT_DIR, which works under both layouts. (cherry picked from commit d504163)
comphead
approved these changes
Nov 17, 2026
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Nov 17, 2026
Picks up apache#7665, which fixes the c_udf cache tests failing in rust-test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Nov 17, 2026
Picks up apache#7665, which fixes the c_udf cache tests failing in rust-test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Nov 17, 2026
Picks up apache#7665, which fixes the c_udf cache tests failing in rust-test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Backport of #7617 to
branch-1.2. Closes #7609 on this branch.Rationale for this change
Rust 1.100 became the stable toolchain on 2026-11-12, and
branch-1.2'srust-toolchain.tomltracksstable. Cargo 1.100 splits a build script'sOUT_DIRintobuild/<pkg>/<hash>/out, so the fixed-depth lookup innative/core/build.rsnow pointsCOMET_TEST_UDFS_LIBattarget/debug/build/libcomet_test_udfs.so. Thec_udfloader tests then fail to load the library, andrust-testfails on every pull request againstbranch-1.2, including the open backports #7513, #7514 and #7515. See #7617 for the full analysis.What changes are included in this PR?
Cherry-pick of d504163 (
git cherry-pick -x) with no conflicts and no adaptations.build.rsnow finds the profile directory as the parent of the nearestbuildancestor ofOUT_DIR, which works under both Cargo layouts.Other release branches:
branch-1.2is the newest release branch.branch-1.1and older don't have thec_udfloader orCOMET_TEST_UDFS_LIB, so they don't need this.How are these changes tested?
On this branch with Rust 1.100.0 (macOS), after
cargo build -p comet-test-udfs, the 42c_udfunit tests pass (cargo test -p datafusion-comet --lib c_udf). Withbuild.rsreverted tobranch-1.2's version, the same tests fail to load the library, which matches therust-testfailures on #7513, #7514 and #7515.🤖 Generated with Claude Code