Repository navigation
fix: fail the task when Spark throws during a native memory request #7607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JonSnow1807
wants to merge
10
commits into
apache:main
Choose a base branch
from
JonSnow1807:fix/7244-memory-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ee9ed30
fix: fail the task when Spark throws during a native memory request
JonSnow1807 52ca65e
refactor: share is_refusal through datafusion-comet-common
JonSnow1807 ae66e79
fix: fail every later memory request with the exception Spark threw
JonSnow1807 113a2d2
docs: note that a failed grow with no later try_grow is only logged
JonSnow1807 323ab8f
fix: stop asking Spark for memory once a request has failed
JonSnow1807 f7670bd
fix: keep an exception Spark threw while a deletion vector reserves m…
JonSnow1807 2e63e3f
docs: name the sort-merge join case of an exception that is only logged
JonSnow1807 15ed9fa
Merge remote-tracking branch 'origin/main' into fix/7244-memory-errors
JonSnow1807 3f70dac
Merge remote-tracking branch 'origin/main' into fix/7244-memory-errors
JonSnow1807 aa14cea
Merge remote-tracking branch 'origin/main' into fix/7244-memory-errors
JonSnow1807 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test overlaps with
a_failed_spark_call_during_the_replay_is_not_recordedinspill_replay.rs. Both run the two pool types, failmerge.grow, check that the replay'stry_growfails withoutResourcesExhausted, and check thatreserved()does not change. This one adds the fair pool's limits and the repeated calls. Could the older test be removed, or extended with the new assertions, so the case is tested in one place? In the same way,a_failed_acquire_fails_every_later_try_acquireinspark_memory.rsrepeats the overcommit and release assertions offailed_acquire_is_all_overcommit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: removed the older replay test and the repeated overcommit and release checks.