Repository navigation
fix: bound the batch under the operator that expands a large string scalar #7316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhangfengcdt
wants to merge
13
commits into
apache:main
Choose a base branch
from
zhangfengcdt:fix/scalar-string-batch-cap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e9b8b0c
fix: cap the rows per batch so a large string scalar fits 32-bit offsets
zhangfengcdt 0e9745e
fix: bound the batch under the operator that expands a large string s…
zhangfengcdt 7448cd1
fix: never measure a volatile expression for the scalar expansion bound
zhangfengcdt cd5dda1
Merge remote-tracking branch 'origin/main' into fix/scalar-string-bat…
zhangfengcdt 9e4b6b0
fix: install the batch split whenever an upstream batch can outgrow t…
zhangfengcdt 74e7aee
fix: split the input of every operator that expands a string scalar
zhangfengcdt 949f550
Merge remote-tracking branch 'origin/main' into fix/scalar-string-bat…
zhangfengcdt 30ee2c7
fix: count scalars beside per-row nodes and bound range partitioning …
zhangfengcdt e19824a
fix: measure per-row IN list members and keep the split transparent t…
zhangfengcdt f3d72bb
Merge remote-tracking branch 'origin/main' into fix/scalar-string-bat…
zhangfengcdt 29ce8c7
fix: skip a scalar a comparison takes as a Datum and bound the sort keys
zhangfengcdt e8eae44
Merge remote-tracking branch 'apache/main' into fix/scalar-string-bat…
a5708d0
fix: split only under a sort with a limit and pull JVM input on demand
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc comment on
pull_input_batchesstill says "we pull input batches here and insert them into scan operators before polling the stream". After this change it only runs from the pending branch ofnext_batch, after a poll, so that comment should change with this one. It also still fills every JVM-fed scan whose slot is empty, not only the one the plan waits on, so with two JVM inputs a pending poll on one side still reads the other side ahead. That part is unchanged frommain, but "only when the stream waits for it" reads stronger than what happens.