Repository navigation
docs: say that Spark 3.5 builds a cache through rows under AQE #7238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andygrove
wants to merge
5
commits into
apache:main
Choose a base branch
from
andygrove:docs/cache-3x-row-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0a06dc7
docs: say that Spark 3.4 and 3.5 build a cache through rows under AQE
andygrove 24fe4a3
Merge remote-tracking branch 'apache/main' into docs/cache-3x-row-build
andygrove f94fe70
docs: limit the AQE cache row-build note to Spark 3.5 and 3.4 with ca…
andygrove 813ddfe
Merge remote-tracking branch 'apache/main' into docs/cache-3x-row-build
andygrove 4816d92
docs: drop the Spark 3.4 case from the AQE cache row-build note
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the same reason, I expect this to fail on Spark 3.4 with
adaptive = true, since the test does not setspark.sql.optimizer.canChangeCachedPlanOutputPartitioningand the cached plan comes back non-adaptive.withAQECacheand the planning test set that conf totruefor exactly this. The description says it passes on 3.4, and I could not find what makes it pass there. I have not run it. Could you recheck withrun-spark-3.4-testsorrun-all-spark-profiles, and set the conf here if needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right: without the conf the test fails on 3.4 (
false did not equal true AQE is true), and my claim that it passed there was wrong. It now setsCAN_CHANGE_CACHED_PLAN_OUTPUT_PARTITIONINGtotrue, aswithAQECachedoes, and passes on 3.4 locally. Fixed in f94fe70.