test: cover lpad and rpad routing configurations - #5895
Open
rich7420 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4616.
Rationale for this change
The
lpadandrpadtests do not verify routing with the codegen dispatcher disabled. Their global dispatcher counters also do not identify which expression ran.What changes are included in this PR?
Check both dispatcher settings in the existing tests. Supported argument shapes must stay native; unsupported shapes must dispatch or fall back with the disabled-dispatcher reason. Replace global counters with expression-specific assertions and remove the redundant
allowIncompatibleloop.How are these changes tested?
All four routing tests pass locally on Spark 4.1 after rebasing, covering 20 query/configuration combinations and comparing results with Spark. Injected routing regressions are caught for both expressions.
Fork CI passed before the rebase and configuration-loop cleanup. CI for the revised head is pending.