feat: add support for url_encode, url_decode, and try_url_decode#4231
Open
parthchandra wants to merge 2 commits intoapache:mainfrom
Open
feat: add support for url_encode, url_decode, and try_url_decode#4231parthchandra wants to merge 2 commits intoapache:mainfrom
parthchandra wants to merge 2 commits intoapache:mainfrom
Conversation
3 tasks
Member
|
Thanks @parthchandra, could you add the tests that I was adding in #4152 ? They covered some edge cases |
Contributor
Author
Sure. Do we want to add parse_url to this PR as well? |
Member
|
I don't mind either way. We can do that as separate PR if easier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4155
Rationale for this change
try_url_decode was returning incorrect results
What changes are included in this PR?
url_encode,url_decode, andtry_url_decode(Spark 4.0+) by wiring up the existingdatafusion-sparkUDFs and handling theStaticInvokeserde forUrlCodec.encode/UrlCodec.decode.try_url_decodewas silently dropping thefailOnError=falseflag, causing Comet to error on malformed input where Spark returns NULL.How are these changes tested?
SQL file tests -
expressions/url/url_decode.sql— valid inputs, malformed input errorsexpressions/url/url_encode.sql— valid inputs, multibyte UTF-8expressions/url/try_url_decode.sql— same inputs as url_decode, malformed input returns NULL