Repository navigation
Conversation
Adapt job ID generation to the v3 clock, async, and base32 APIs and refresh the lockfile.
milenkovicm
reviewed
Nov 19, 2026
milenkovicm
left a comment
Contributor
There was a problem hiding this comment.
Thanks @s0l0ist update makes sense, one comment inline
| /// which does not capture machine id as part result. | ||
| pub(crate) struct DefaultJobGenerator { | ||
| generator: AtomicSnowflakeGenerator<SnowflakeMastodonId, MonotonicClock>, | ||
| generator: AtomicSnowflakeGenerator<SnowflakeMastodonId, CachedClock>, |
Contributor
There was a problem hiding this comment.
CachedClock or DirectClock 🤔 starting a thread or reading time on every call?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Upgrade the scheduler to ferroid 3.x. The latest version has substantial performance improvements for Base32 encoding.
What changes are included in this PR?
Update the ferroid dependency, adapt job ID generation to the v3 clock, async, and base32 APIs, and refresh the lockfile.
Are there any user-facing changes?
No