Implemented Data Editor Message Registry#1716
Conversation
f94da23 to
f2d91e0
Compare
|
Looks like I'll have to fix tests due to the strict type checks when transpiling with |
13cb602 to
a72d6ca
Compare
|
Disregard, I fixed this issue. |
c99639a to
9c28091
Compare
|
Some changes needed to be made in order to get the updated data editor files to function properly for CI. Everything should be good to go, now. |
|
@stricklandrbls Is this PR ready to test? |
Yes it is ready |
|
Going to sift through and implement resolutions for import strings as referenced here |
e5101a8 to
a8dd573
Compare
|
The svelte imports should now all be aliased if the path is not a sub-directory of its path. The rest of the extension imports still need to be updated. |
|
@stricklandrbls , I did some testing on this code and found that the data editor does not open automatically when starting debug. Wondering if some messages are missing? The status bar at the bottom shows no indication that it is even trying to connect to the server. |
Awesome thanks for testing this. I'll take a look |
a8dd573 to
c648f68
Compare
|
@lrbarber The latest commit should fix the issue of the Data Editor not opening for the target data file in a debug session. |
c648f68 to
886c848
Compare
Closes #1659
Closes #1469
Closes #1058
Closes #669
Description
Wiki
Review Instructions including Screenshots
Developer Perspective Reviews
this.panel.postMessage(...).Screenshots ( dataEditorClient.ts -> 'fileInfo')
addListener(...).Screenshots ( DataEditorLineFeed.svelte -> 'viewportRefresh')
vscode.postMessage(...).Screenshots ( App.svelte -> 'requestEditedData')
Functionality Review
Verify that all message traffic behaves as expected. Message content can be identified within the ./src/ext_types/message.ts & ./src/ext_types/messageContent.ts