Show infoset actions throughout active debug sessions#1705
Open
999axel999 wants to merge 2 commits into
Open
Conversation
999axel999
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the extension’s VS Code menu contributions so the infoset-related editor title actions are visible throughout an active debug session, addressing issue #1703 where those actions were missing when focus wasn’t on a DFDL editor.
Changes:
- Relax
infoset.displayandinfoset.diffeditor/titlemenu visibility conditions frominDebugMode && editorLangId == 'dfdl'toinDebugMode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
223
to
230
| "command": "infoset.display", | ||
| "when": "inDebugMode && editorLangId == 'dfdl'", | ||
| "when": "inDebugMode", | ||
| "group": "navigation@2" | ||
| }, | ||
| { | ||
| "command": "infoset.diff", | ||
| "when": "inDebugMode && editorLangId == 'dfdl'", | ||
| "when": "inDebugMode", | ||
| "group": "navigation@3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1703
Description
infoset.displayandinfoset.diffwhenever a debug session is active, regardless of the focused editor language.inDebugModecontext used by VS Code.Wiki
Review Instructions including Screenshots
node -e "const p=require('./package.json'); const items=p.contributes.menus['editor/title'].filter(x=>x.command==='infoset.display'||x.command==='infoset.diff'); if(items.some(x=>x.when!=='inDebugMode')) process.exit(1);"Prepared with local automation assistance and reviewed before submission.