Skip to content

fix(SystemBarPlugin): remove canEdgeToEdge check for execute method#1971

Merged
erisu merged 1 commit into
masterfrom
pr-fix-SystemBarPlugin-remove-canEdgeToEdge-check-for-execute
Jul 18, 2026
Merged

fix(SystemBarPlugin): remove canEdgeToEdge check for execute method#1971
erisu merged 1 commit into
masterfrom
pr-fix-SystemBarPlugin-remove-canEdgeToEdge-check-for-execute

Conversation

@GitToTheHub

@GitToTheHub GitToTheHub commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Platforms affected

Motivation and Context

Setting StatusBarBackgroundColor by config.xml is allowed and influences the light/dark appeareance of the status bar in edge-to-edge mode. This should also be possible by the Status Bar JS API method setBackgroundColor, so a user can dynamically change the light/dark appeareance of the status bar, even if the background color is not applied visually.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Setting `StatusBarBackgroundColor` by `config.xml` is allowed and influences the light/dark appeareance of the status bar in edge-to-edge mode. This should also be possible by the Status Bar JS API method `setBackgroundColor``, so a user can dynamically change the light/dark appeareance of the status bar, even if the background color is not applied visually.
@codecov-commenter

codecov-commenter commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.20%. Comparing base (cdbeb60) to head (806f5a2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1971   +/-   ##
=======================================
  Coverage   63.20%   63.20%           
=======================================
  Files          24       24           
  Lines        4922     4922           
=======================================
  Hits         3111     3111           
  Misses       1811     1811           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

I also tested a build and run and didn't see any issues or logcat warnings.

@erisu
erisu merged commit 61ebdcd into master Jul 18, 2026
29 checks passed
@erisu
erisu deleted the pr-fix-SystemBarPlugin-remove-canEdgeToEdge-check-for-execute branch July 18, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants