fix(SystemBarPlugin): remove canEdgeToEdge check for execute method#1971
Merged
erisu merged 1 commit intoJul 18, 2026
Merged
Conversation
- Setting `StatusBarBackgroundColor` by `config.xml` is allowed and influences the light/dark appeareance of the status bar in edge-to-edge mode. This should also be possible by the Status Bar JS API method `setBackgroundColor``, so a user can dynamically change the light/dark appeareance of the status bar, even if the background color is not applied visually.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1971 +/- ##
=======================================
Coverage 63.20% 63.20%
=======================================
Files 24 24
Lines 4922 4922
=======================================
Hits 3111 3111
Misses 1811 1811 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
erisu
approved these changes
Jul 18, 2026
erisu
left a comment
Member
There was a problem hiding this comment.
Looks OK.
I also tested a build and run and didn't see any issues or logcat warnings.
erisu
deleted the
pr-fix-SystemBarPlugin-remove-canEdgeToEdge-check-for-execute
branch
July 18, 2026 04:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
Setting
StatusBarBackgroundColorbyconfig.xmlis allowed and influences the light/dark appeareance of the status bar in edge-to-edge mode. This should also be possible by the Status Bar JS API methodsetBackgroundColor, so a user can dynamically change the light/dark appeareance of the status bar, even if the background color is not applied visually.Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))