fixes #VFS-834: Updated to avoid prematurely closing file objects.#383
Open
ivakegg wants to merge 4 commits intoapache:masterfrom
Open
fixes #VFS-834: Updated to avoid prematurely closing file objects.#383ivakegg wants to merge 4 commits intoapache:masterfrom
ivakegg wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Working on a test case that demonstrates the issue... |
commons-vfs2/src/test/java/org/apache/commons/vfs2/AbstractProviderTestCase.java
Outdated
Show resolved
Hide resolved
Member
|
This use case will require careful study because VFS is not built for multi-threading, and in general, getting a list of URLs should not permanently allocate resources. |
Contributor
Author
|
@garydgregory This is not a multi-threading issue. This is an issue where multiple resources are loaded for the same file in the SAME thread. Then the input stream of one is closed before the other is read. Apparently this can happen with spring when loading a context. |
reason why additional step could not be taken
ivakegg
force-pushed
the
bugfix/prematureClose
branch
from
b2f9b50 to
7923cac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.