Skip to content

[NET-745] Clarify UnixFTPEntryParser trimLeadingSpaces in Javadoc #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 2 commits into from
Jul 22, 2026
+6 −0
Merged

[NET-745] Clarify UnixFTPEntryParser trimLeadingSpaces in Javadoc #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e083d7
[NET-745] Clarify UnixFTPEntryParser trimLeadingSpaces in Javadoc
Jul 22, 2026
4cf1f57
Refine comments on leading spaces in UnixFTPEntryParser
garydgregory Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
* This class is based on the logic of Daniel Savarese's DefaultFTPListParser, but adapted to use regular expressions and to fit the new FTPFileEntryParser
* interface.
* </p>
* <p>
* By default, leading spaces in parsed file names are preserved because Unix file names may legitimately begin with spaces. However, some FTP servers,
* including IBM i (formerly OS/400) systems that return Unix-style listings, pad the date field with additional spaces when displaying a year instead
* of a time for older entries. As a result, parsed file names may incorrectly include a leading space. To remove these unintended spaces, use the
* {@link #UnixFTPEntryParser(FTPClientConfig, boolean)} constructor with {@code trimLeadingSpaces} set to {@code true}.
* </p>
*
* @see org.apache.commons.net.ftp.FTPFileEntryParser FTPFileEntryParser (for usage instructions)
*/
Expand Down
Loading