Add boundary tests for BinaryCodec.fromAscii partial-bit inputs#425
Merged
garydgregory merged 2 commits intoapache:masterfrom Feb 27, 2026
Merged
Add boundary tests for BinaryCodec.fromAscii partial-bit inputs#425garydgregory merged 2 commits intoapache:masterfrom
garydgregory merged 2 commits intoapache:masterfrom
Conversation
garydgregory
requested changes
Feb 27, 2026
Member
garydgregory
left a comment
There was a problem hiding this comment.
Hello @pdtx
Thank you for your PR.
Update the existing testFromAsciiCharArray(), testFromAsciiByteArray(), and testToAsciiString().
Thank you!
|
|
||
| @Test | ||
| void testToAsciiStringNullReturnsEmptyString() { | ||
| assertEquals("", BinaryCodec.toAsciiString(null)); |
Member
There was a problem hiding this comment.
Make this edge case the first assertion in testToAsciiString().
Contributor
Author
|
Thanks for the review. Updated as requested: I folded the new assertions into the existing |
70436c2 to
3da6d7a
Compare
Member
|
Hello @pdtx Thank you for the update. Please rebate on git master. |
Contributor
Author
|
Thanks for the note. Rebased on the latest |
Member
|
@pdtx |
garydgregory
added a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinaryCodec.fromAscii(byte[])andBinaryCodec.fromAscii(char[])when input length is less than 8 bits.BinaryCodec.toAsciiString(byte[]).Why
Current tests cover null/empty and exact 8-bit aligned inputs, but do not explicitly cover short non-empty inputs or partial-bit-length inputs.
These boundary cases are easy to regress (for example, through off-by-one or grouping changes), so explicit tests improve behavioral stability.
Verification
mvn -Dtest=BinaryCodecTest test