[CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions by marchpure · Pull Request #4026 · apache/carbondata

marchpure · 2020-11-26T11:48:45Z

Why is this PR needed?

Currently, getBlockId and getShortBlockId functions are too complex and unreadable, which can be more simpler and readable.

What changes were proposed in this PR?

Refactor the getBlockId and getShortBlockId functions without changing the blockid format and shortblockid format, There is no complatiability issue after the rafactoring.

Does this PR introduce any user interface change?

No

Is any new testcase added?

No

CarbonDataQA2 · 2020-11-26T13:34:18Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4920/

CarbonDataQA2 · 2020-11-26T13:39:36Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3165/

CarbonDataQA2 · 2020-11-26T18:42:07Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4931/

CarbonDataQA2 · 2020-11-26T18:43:13Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3177/

CarbonDataQA2 · 2020-11-27T01:08:39Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4934/

CarbonDataQA2 · 2020-11-27T01:10:35Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3180/

CarbonDataQA2 · 2020-11-27T03:43:25Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4938/

CarbonDataQA2 · 2020-11-27T03:44:59Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3183/

CarbonDataQA2 · 2020-11-27T03:54:51Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3187/

CarbonDataQA2 · 2020-11-27T03:55:41Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4942/

CarbonDataQA2 · 2020-11-27T09:20:02Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4948/

CarbonDataQA2 · 2020-11-27T09:25:54Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3193/

CarbonDataQA2 · 2020-11-27T11:29:24Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4953/

CarbonDataQA2 · 2020-11-27T11:35:04Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3198/

CarbonDataQA2 · 2020-11-27T14:55:56Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3204/

CarbonDataQA2 · 2020-11-27T14:57:54Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4959/

CarbonDataQA2 · 2020-11-28T04:54:51Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3209/

CarbonDataQA2 · 2020-11-28T04:56:54Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4964/

CarbonDataQA2 · 2020-11-28T11:14:41Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3211/

CarbonDataQA2 · 2020-11-28T11:16:00Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4966/

CarbonDataQA2 · 2020-11-28T17:15:27Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4967/

CarbonDataQA2 · 2020-11-28T17:15:59Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3212/

CarbonDataQA2 · 2020-11-30T08:29:20Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3217/

CarbonDataQA2 · 2020-11-30T08:30:09Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4972/

CarbonDataQA2 · 2020-11-30T10:20:29Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4973/

CarbonDataQA2 · 2020-11-30T10:33:45Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3218/

Kejian-Li · 2020-11-30T14:03:16Z

LGTM

marchpure · 2020-12-01T16:42:57Z

retest this please

CarbonDataQA2 · 2020-12-01T18:23:29Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5000/

CarbonDataQA2 · 2020-12-01T18:40:22Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3245/

QiangCai · 2020-12-02T11:33:10Z

core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java

+    return filePath.substring(tablePath.length() + 1, filePath.length() - blockName.length() - 1);
  }

+


revert this change

Why is this PR needed? Currently, getBlockId and getShortBlockId functions are too complex and unreadable, which can be more simpler and readable. What changes were proposed in this PR? Refactor the getBlockId and getShortBlockId functions without changing the blockid format and shortblockid format, There is no complatiability issue after the rafactoring. Does this PR introduce any user interface change? No Is any new testcase added? No

CarbonDataQA2 · 2020-12-02T16:15:15Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5031/

CarbonDataQA2 · 2020-12-02T16:21:52Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3274/

marchpure force-pushed the blockid_codeclean branch from 7aff1ba to 3272c9e Compare November 26, 2020 16:57

marchpure force-pushed the blockid_codeclean branch from 3272c9e to ede2c54 Compare November 26, 2020 23:20

marchpure force-pushed the blockid_codeclean branch from ede2c54 to 40d7077 Compare November 27, 2020 01:59

marchpure force-pushed the blockid_codeclean branch from 40d7077 to 61f7f07 Compare November 27, 2020 03:50

marchpure force-pushed the blockid_codeclean branch from 61f7f07 to 02e5d41 Compare November 27, 2020 07:36

marchpure force-pushed the blockid_codeclean branch from 02e5d41 to 7b98a82 Compare November 27, 2020 09:45

marchpure force-pushed the blockid_codeclean branch from 7b98a82 to 3f1838d Compare November 27, 2020 13:08

marchpure force-pushed the blockid_codeclean branch from 3f1838d to ef57e03 Compare November 28, 2020 03:15

marchpure force-pushed the blockid_codeclean branch from ef57e03 to 83cebde Compare November 28, 2020 11:11

marchpure force-pushed the blockid_codeclean branch from 83cebde to 0b19d45 Compare November 28, 2020 15:28

marchpure force-pushed the blockid_codeclean branch from 0b19d45 to c0833af Compare November 30, 2020 08:25

marchpure changed the title ~~[WIP] blockid code clean~~ [CARBONDATA-4063] Refactor getBlockId and getShortBlcokId founctions Nov 30, 2020

marchpure force-pushed the blockid_codeclean branch from c0833af to 840a576 Compare November 30, 2020 08:35

marchpure changed the title ~~[CARBONDATA-4063] Refactor getBlockId and getShortBlcokId founctions~~ [CARBONDATA-4063] Refactor getBlockId and getShortBlcokId functions Nov 30, 2020

marchpure changed the title ~~[CARBONDATA-4063] Refactor getBlockId and getShortBlcokId functions~~ [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions Nov 30, 2020

QiangCai reviewed Dec 2, 2020

View reviewed changes

marchpure force-pushed the blockid_codeclean branch from 840a576 to 2343d4b Compare December 2, 2020 14:32

		return filePath.substring(tablePath.length() + 1, filePath.length() - blockName.length() - 1);
		}

Conversation

marchpure commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this PR needed?

What changes were proposed in this PR?

Does this PR introduce any user interface change?

Is any new testcase added?

Uh oh!

CarbonDataQA2 commented Nov 26, 2020

Uh oh!

CarbonDataQA2 commented Nov 26, 2020

Uh oh!

CarbonDataQA2 commented Nov 26, 2020

Uh oh!

CarbonDataQA2 commented Nov 26, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 27, 2020

Uh oh!

CarbonDataQA2 commented Nov 28, 2020

Uh oh!

CarbonDataQA2 commented Nov 28, 2020

Uh oh!

CarbonDataQA2 commented Nov 28, 2020

Uh oh!

CarbonDataQA2 commented Nov 28, 2020

Uh oh!

CarbonDataQA2 commented Nov 28, 2020

Uh oh!

CarbonDataQA2 commented Nov 28, 2020

Uh oh!

CarbonDataQA2 commented Nov 30, 2020

Uh oh!

CarbonDataQA2 commented Nov 30, 2020

Uh oh!

CarbonDataQA2 commented Nov 30, 2020

Uh oh!

CarbonDataQA2 commented Nov 30, 2020

Uh oh!

Kejian-Li commented Nov 30, 2020

Uh oh!

marchpure commented Dec 1, 2020

Uh oh!

CarbonDataQA2 commented Dec 1, 2020

Uh oh!

CarbonDataQA2 commented Dec 1, 2020

Uh oh!

QiangCai Dec 2, 2020

Choose a reason for hiding this comment

Uh oh!

marchpure Dec 2, 2020

Choose a reason for hiding this comment

Uh oh!

CarbonDataQA2 commented Dec 2, 2020

Uh oh!

CarbonDataQA2 commented Dec 2, 2020

Uh oh!

Reviewers

Assignees

marchpure commented Nov 26, 2020 •

edited

Loading