[CARBONDATA-4045] Add TPCDS TestCase for Spark on CarbonData Integration Test by marchpure · Pull Request #3997 · apache/carbondata

marchpure · 2020-10-25T06:21:50Z

Why is this PR needed?

There is no TPC-DS TestCases in the current source code. It is difficult to debug TPC-DS on small dataset. Also, TPC-DS TestCase would help to find possible issues

What changes were proposed in this PR?

Add small dataset of TPCDS
Add SQL of TPCDS
Add 54 Testcases (There are 99 testcases in TPCDS, but only 54 testcases can run without empty result)

Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

CarbonDataQA1 · 2020-10-25T06:57:24Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2920/

CarbonDataQA1 · 2020-10-25T06:57:27Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4677/

CarbonDataQA1 · 2020-10-25T15:28:57Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2921/

CarbonDataQA1 · 2020-10-25T15:29:28Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4678/

marchpure · 2020-10-25T15:39:58Z

retest this please

CarbonDataQA1 · 2020-10-25T16:33:59Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2923/

CarbonDataQA1 · 2020-10-25T16:34:31Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4680/

CarbonDataQA1 · 2020-10-25T23:26:35Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4681/

CarbonDataQA1 · 2020-10-25T23:30:07Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2924/

CarbonDataQA1 · 2020-10-26T03:01:27Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2927/

CarbonDataQA1 · 2020-10-26T03:03:14Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4684/

CarbonDataQA1 · 2020-10-26T10:25:37Z

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4690/

CarbonDataQA1 · 2020-10-26T10:27:28Z

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2933/

CarbonDataQA1 · 2020-10-26T13:56:39Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4693/

CarbonDataQA1 · 2020-10-26T13:58:39Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2936/

Why is this PR needed? There is no TPC-DS TestCases in the current source code. It is difficult to debug TPC-DS on small dataset. Also, TPC-DS TestCase would help to find possible issues What changes were proposed in this PR? 1) Add small dataset of TPCDS 2) Add SQL of TPCDS 3) Add 54 Testcases (There are 99 testcases in TPCDS, but only 54 testcases can run without empty result) Does this PR introduce any user interface change? No Is any new testcase added? Yes

CarbonDataQA1 · 2020-10-27T06:28:36Z

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4697/

CarbonDataQA1 · 2020-10-27T06:30:09Z

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2940/

ajantha-bhat · 2020-10-27T06:58:37Z

@marchpure : The reason why we don't have TPCH and TPCDS in UT is we need a huge data set, loading huge data takes time.

What is the reason behind adding this? we can anyways have separate TPCH or TPCDS machines that can have automation script to give performance benchmark on every release

Also no need to run TPCH and TPCDS on every PR builder. Running once per release is enough.

@QiangCai , @kunal642 : What's your opinion on this?

marchpure · 2020-10-27T07:28:03Z

@marchpure : The reason why we don't have TPCH and TPCDS in UT is we need a huge data set, loading huge data takes time.

What is the reason behind adding this? we can anyways have separate TPCH or TPCDS machines that can have automation script to give performance benchmark on every release

Also no need to run TPCH and TPCDS on every PR builder. Running once per release is enough.

@QiangCai , @kunal642 : What's your opinion on this?

The TPCDS dataset in this PR is really small(totally 33KB). it won"t took so much time to load and query. It may help to avoid possible issues with accepted overhead.
it also help us to debug tpcds. explain plan ～analyse in local environment.

the inspiration to add tpcds test case is CARBONDATA 4008. Whose issue is Spark on CarbonData will fail in TPCDS Query 83. This issue seems has been there for a log time, which implies that our UT is not enough.
I believe that we can add a profile to turn on/off of TPCDS test in the future if the automatic TPCDS machine is ready.

Maybe we can have a module name 'carbondata-integretion-test'?

marchpure force-pushed the tpcds branch from 7f9f2cc to 8ca6475 Compare October 25, 2020 14:33

marchpure changed the title ~~[WIP]Add TPCDS TestCase~~ [WIP] Add TPCDS TestCase Oct 25, 2020

marchpure force-pushed the tpcds branch from 8ca6475 to 4fc9b6a Compare October 25, 2020 23:07

marchpure force-pushed the tpcds branch from 4fc9b6a to 93a4868 Compare October 26, 2020 02:24

marchpure force-pushed the tpcds branch from 93a4868 to ffdc231 Compare October 26, 2020 08:46

marchpure force-pushed the tpcds branch from ffdc231 to 2c03328 Compare October 26, 2020 12:13

marchpure force-pushed the tpcds branch from 2c03328 to c6d44e3 Compare October 27, 2020 04:46

marchpure changed the title ~~[WIP] Add TPCDS TestCase~~ [CARBONDATA-4045] Add TPCDS TestCase Oct 27, 2020

marchpure changed the title ~~[CARBONDATA-4045] Add TPCDS TestCase~~ [CARBONDATA-4045] Add TPCDS TestCase for Spark Integration Testing Oct 27, 2020

marchpure changed the title ~~[CARBONDATA-4045] Add TPCDS TestCase for Spark Integration Testing~~ [CARBONDATA-4045] Add TPCDS TestCase for Spark Integration Test Oct 27, 2020

marchpure changed the title ~~[CARBONDATA-4045] Add TPCDS TestCase for Spark Integration Test~~ [CARBONDATA-4045] Add TPCDS TestCase for Spark on CarbonData Integration Test Oct 27, 2020

Conversation

marchpure commented Oct 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this PR needed?

What changes were proposed in this PR?

Does this PR introduce any user interface change?

Is any new testcase added?

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

marchpure commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 25, 2020

Uh oh!

CarbonDataQA1 commented Oct 26, 2020

Uh oh!

CarbonDataQA1 commented Oct 26, 2020

Uh oh!

CarbonDataQA1 commented Oct 26, 2020

Uh oh!

CarbonDataQA1 commented Oct 26, 2020

Uh oh!

CarbonDataQA1 commented Oct 26, 2020

Uh oh!

CarbonDataQA1 commented Oct 26, 2020

Uh oh!

CarbonDataQA1 commented Oct 27, 2020

Uh oh!

CarbonDataQA1 commented Oct 27, 2020

Uh oh!

ajantha-bhat commented Oct 27, 2020

Uh oh!

marchpure commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marchpure commented Oct 25, 2020 •

edited

Loading

marchpure commented Oct 27, 2020 •

edited

Loading