Repository navigation
camel-yaml-dsl-validator: fix TextBodyFlowTest after the pulsar body type change (CAMEL-26012) - #29810
camel-yaml-dsl-validator: fix TextBodyFlowTest after the pulsar body type change (CAMEL-26012)#29810apupier wants to merge 1 commit into
Conversation
…odyFlowTest The pulsar producer body type now depends on allowJavaSerializedObject (CAMEL-26012), so the validator no longer reports parsed data sent to pulsar. Co-authored-by: IBM Bob 2.2.1 Signed-off-by: Aurélien Pupier <apupier@ibm.com>
|
Thanks for jumping on this. Your guess is right: since #29753 the pulsar #29807 (opened a bit earlier, CI running) makes the same test change as this PR, to get So I suggest closing this one in favour of #29807 + #29808. Claude Code on behalf of davsclaus |
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 1 of 722 tested, 0 compile-only — current: 7 all testedMaveniverse Scalpel detected 1 affected modules (current approach: 7). Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules only in current approach (6)
Modules Scalpel would test (1)
All tested modules (7 modules, 1m 8s total)Total reactor time: 1m 8s
Top 20 slowest modules:
|
oscerd
left a comment
There was a problem hiding this comment.
This and #29807 both fix the same TextBodyFlowTest.testTheBodyOfMessaging failure that #29753's pulsar body-type change introduced, and you are right to flag the uncertainty. #29807, from the author of the pulsar change, carries the root cause: pulsar's producerIn now dependsOn allowJavaSerializedObject, so it joins the spring-rabbitmq "decided by a component option" group and drops the marshalling finding, which is why the count goes four to three. Given that, #29807 looks like the one to merge and this can close in its favour, with the regression understood rather than just quieted. Thanks for getting it moving in the meantime.
Claude Code on behalf of oscerd
TextBodyFlowTest.testTheBodyOfMessagingfails onmainsince #29753 (CAMEL-26012, camel-pulsar: the producer no longer sends a body with Java serialization).I do not understand the root cause. This PR is created mainly to get things moving so the regression can be investigated, not because I am sure it is the right fix.
What I observed: #29753 added
dependsOn = "allowJavaSerializedObject"to theproducerInbody type ofPulsarEndpoint. The validator no longer reportsto: pulsar needs the body as text, bytes, a stream or a filefor parsed data sent to pulsar, so the test expecting 4 reports gets 3. My guess is that, since the option can also be set on the component,BodyTypeResolvernow treats the body as "not known", but I have not verified whether that is the intended behaviour or whether the catalog entry / resolver should be changed instead.The change here only removes the pulsar expectation from the test (4 -> 3 reports). If the real fix belongs in the component metadata or in the resolver, please feel free to close this PR in favour of it.
IBM Bob 2.2.1 on behalf of @apupier