[Spark][#36841] Reuse the legacy maxRecordsPerBatch option in the Structured Streaming runner - #39952
Merged
Conversation
…d Streaming runner Replaces the structured streaming specific maxRecordsPerMicroBatch with a declaration mirroring SparkPipelineOptions#getMaxRecordsPerBatch exactly, Long with default -1, so the flag carries over when migrating from the legacy runner. Identical signatures share one options proxy, which the new test locks down.
tkaymak
changed the title
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Abacn
approved these changes
Sep 1, 2026
Contributor
|
PreCommit Java failing due to breakage on HEAD, not related to this change, merging for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to the review discussion on #39906, #39906 (comment). Addresses #36841.
Replaces the structured streaming specific maxRecordsPerMicroBatch with a declaration mirroring SparkPipelineOptions#getMaxRecordsPerBatch exactly, Long with default -1, so the flag carries over when users migrate from the legacy runner.
Identical signatures share one PipelineOptionsFactory proxy and the new SparkStructuredStreamingPipelineOptionsTest locks that down: a value set through one interface is readable through the other, and the flag parses from args.
Nothing consumes the option on master yet, the streaming source arriving with the next slice will read it and treat values below 1 as unlimited, matching the legacy semantics.
R: @Abacn