normalize firestoreIO - #39941
Open
aIbrahiim wants to merge 5 commits into
Open
Conversation
Contributor
|
Same as other IOs, we should be able to add a basic integration test (e.g. in extended tests), one can use 'firestoredb' as default firestore database, like other tests did |
Contributor
Author
|
Run Yaml_Xlang_Direct PostCommit databases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Java SchemaTransform providers for Firestore read and write so Firestore can be used from Beam YAML
Read (firestore_read:v1) lists documents from a collection and outputs Beam Rows using a JSON schema. Write (firestore_write:v1) takes Rows and upserts them with batchWrite. FirestoreUtils handles document toRow conversion, with config classes for both sides.
Registers ReadFromFirestore and WriteToFirestore in standard_io.yaml, pointing at the GCP expansion service jar.
Unit tests: FirestoreSchemaTransformProviderTest and FirestoreUtilsTest.
I validated locally:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.