Skip to content

ARTEMIS-5896 Bump com.google.errorprone:error_prone_core from 2.42.0 to 2.47.0#6228

Open
jbertram wants to merge 1 commit intoapache:mainfrom
jbertram:ARTEMIS-5896
Open

ARTEMIS-5896 Bump com.google.errorprone:error_prone_core from 2.42.0 to 2.47.0#6228
jbertram wants to merge 1 commit intoapache:mainfrom
jbertram:ARTEMIS-5896

Conversation

@jbertram
Copy link
Contributor

@jbertram jbertram commented Feb 10, 2026

Aside from the upgrade, this restricts ErrorProne to Java 25 and beyond. Technically speaking, it could run on 21, but that also requires a JDK parameter that is exclusively for 21. Restricting to 25 is the simplest solution without any meaningful down-sides.

@jbertram jbertram changed the title ARTEMIS-5896 Bump com.google.errorprone:error_prone_core from 2.42.0 … ARTEMIS-5896 Bump com.google.errorprone:error_prone_core from 2.42.0 to 2.47.0 Feb 10, 2026
@gemmellr
Copy link
Member

I didnt really like the idea of this since folks may have existing setups that use 17 / 21 with it enabled currently and will then silently no longer get these checks even though they may still think they are (the build time difference, and lack of log spam, would be hints...but still not everyone will spot it changing).

Of course, I didnt particularly like any of the alternatives either (such as making it fail in those cases, or even using different versions for different JDKs, and they hadnt even done the 'requires additional flag for JDK21' change last time I looked either) which is why I hadnt done anything about it since #5824. Hmm..

@jbertram
Copy link
Contributor Author

We could add a blurb in versions.adoc so folks know it's only enabled on 25 now. There's no great options here, just less bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants