Repository navigation
GH-55636: [C++] Fix logb results for zero input - #55666
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #55636.
logb(0, base)returned negative infinity for bases between zero and one, and for NaN or infinite bases.What changes are included in this PR?
For zero input, the unchecked kernel returns positive infinity for finite bases between zero and one, negative infinity for finite bases at least one, and NaN for nonpositive or nonfinite bases. The kernel determines these results without evaluating a logarithm at zero.
Are these changes tested?
The new assertions failed on the original C++ kernel for both float and double. After the fix, the scalar math test executable reported 595 passed and 28 skipped. The C++ formatting and lint checks also passed.
Are there any user-facing changes?
The corrected results are visible through the C++ compute function and
pyarrow.compute.logb.Was AI used for this PR?
Codex generated the C++ change, regression test, and PR description and reviewed the patch and test results.
PR code and description written by
Reviewed before submission by