Repository navigation
MINOR: [C++][Parquet] Clean up chunker test assertions - #55637
Merged
Merged
Conversation
Fix spelling errors, remove a duplicate dictionary-page assertion, use empty() for empty diff checks, and avoid copying page-length metadata in the content-defined chunking tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open issue
Review effort: Lite
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
1 resolved since last review
Review effort: Lite
Copilot stopped reviewing on behalf of
Sumdiboii due to an error
November 16, 2026 16:48
Contributor
Author
|
The three failing checks seem unrelated to this PR |
wgtmac
approved these changes
Nov 17, 2026
Member
|
Thanks @Sumdiboii! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rationale for this change
I have been studying the Apache Arrow codebase for the past couple of weeks and am still relatively new to open source. I had my first documentation fix merged a couple of days ago, and while continuing to read through the C++ and Parquet code, I noticed a few small cleanup opportunities in the content-defined chunking tests and related documentation comments.
These changes are intentionally small and do not alter production behavior. They improve readability, remove an unnecessary copy, and clean up an accidental duplicate assertion.
What changes are included in this PR?
Fix four spelling errors in C++ comments:
preceedingtoprecedingspecifedtospecifieddeterminisictodeterministiclenghttolengthReplace
diffs.size() == 0withdiffs.empty()in the page-length assertion helpers. This expresses the intent more directly and is the idiomatic way to check whether a container has no elements.Remove a duplicated dictionary-page assertion in
AssertContentDefinedChunkSizes.The duplicate initially caught my attention because I was unsure whether the two identical assertions were intended as some kind of additional failure protection. After looking into the helper's callers, the original commit, and GoogleTest's assertion behavior, I found that both assertions checked exactly the same condition. Since
ASSERT_EQis fatal and returns from the helper when it fails, the second assertion would never run after a failure in the first one. When the first assertion passes, the second one does not provide any additional coverage, so it was redundant.Change the local
page_lengthsvariable to aconstreference to avoid copying the page-length vector unnecessarily.Are these changes tested?
No runtime tests were run. The changes are limited to comments and small test-code cleanups, with no production behavior or public API changes.
git diff --checkwas run successfully though. A focused C++ test build was not available in the checkout, so the Parquet test suite was not run locally.Are there any user-facing changes?
No. These are test and comment cleanups only.
Was AI used for this PR?
AI was used to help search through the codebase, investigate the history and behavior of the duplicated assertion, and review the proposed small cleanup changes. The changes and reasoning were all reviewed before submission.
PR code and description written by:
Reviewed before submission by:
Note - The duplicated assertion seemed redundant based on the current helper behavior and GoogleTest's fatal assertion semantics. If it was originally intended to serve a purpose that I have overlooked, please let me know and I would be happy to revise my change.